Skip to content

Remove containerPackageInfo parameter in createOdspCreateContainerRequest#24456

Closed
MarioJGMsoft wants to merge 2 commits intomicrosoft:mainfrom
MarioJGMsoft:removePackageParameter
Closed

Remove containerPackageInfo parameter in createOdspCreateContainerRequest#24456
MarioJGMsoft wants to merge 2 commits intomicrosoft:mainfrom
MarioJGMsoft:removePackageParameter

Conversation

@MarioJGMsoft
Copy link
Copy Markdown
Contributor

@MarioJGMsoft MarioJGMsoft commented Apr 24, 2025

Description
With PR: #22849 we introduced a parameter for ODSP that will not be used.
Since it is public, we will first mark it as deprecated, and then in the next release remove it. Make sure we inform Loop to not take dependency on it.

This is the follow up task to ensure that the parameter is deleted.

Reviewer Guidance
Please let me know if there's anything that I should change or be aware of. Thanks!

Fixes: AB#31049

@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: tree area: driver Driver related issues area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: odsp-driver area: tests Tests to add, test infrastructure improvements, etc public api change Changes to a public API base: main PRs targeted against main branch labels Apr 24, 2025
@MarioJGMsoft MarioJGMsoft linked an issue Apr 24, 2025 that may be closed by this pull request
[Won't Fix] Remove parameter in createOdspCreateContainerRequest() in v2.40 #23882
Closed
@github-actions github-actions bot added area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: dds Issues related to distributed data structures and removed area: dds Issues related to distributed data structures area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: dds: tree labels May 19, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 19, 2025

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  210260 links
    1663 destination URLs
    1895 URLs ignored
       0 warnings
       0 errors

@MarioJGMsoft MarioJGMsoft deleted the removePackageParameter branch May 28, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

area: dds Issues related to distributed data structures area: driver Driver related issues area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: odsp-driver area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch public api change Changes to a public API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Won't Fix] Remove parameter in createOdspCreateContainerRequest() in v2.40

1 participant

@MarioJGMsoft